MehmetAzizYirik / MAYGEN

MAYGEN is an open source chemical structure generator based on the orderly graph generation method.
MIT License
47 stars 16 forks source link

Syncronyzation classes and unit tests with cdk. #119

Closed javadev closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #119 (b0dfe93) into main (a7b5eae) will increase coverage by 2.06%. The diff coverage is 52.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #119      +/-   ##
============================================
+ Coverage     83.94%   86.01%   +2.06%     
+ Complexity      636      590      -46     
============================================
  Files             7        8       +1     
  Lines          2199     2052     -147     
  Branches        484      400      -84     
============================================
- Hits           1846     1765      -81     
+ Misses          233      201      -32     
+ Partials        120       86      -34     
Impacted Files Coverage Δ
src/main/java/maygen/BoundaryConditions.java 94.11% <ø> (ø)
src/main/java/maygen/SdfAndSmiOutputConsumer.java 13.79% <13.79%> (ø)
src/main/java/maygen/MaygenCLI.java 79.05% <32.25%> (ø)
src/main/java/maygen/SdfOutputConsumer.java 47.82% <47.82%> (ø)
src/main/java/maygen/SmiOutputConsumer.java 54.83% <54.83%> (ø)
src/main/java/maygen/Maygen.java 89.59% <83.33%> (+1.02%) :arrow_up:
src/main/java/maygen/Generation.java 94.44% <100.00%> (+7.26%) :arrow_up:
src/main/java/maygen/HydrogenDistributor.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7b5eae...b0dfe93. Read the comment docs.

javadev commented 2 years ago

@MehmetAzizYirik these classes have been copied from cdk repository. After the release of version 2.8 the library may be reused and only CLI file will be in the repository. The number of dependencies was reduced as result the resulted jar file is 2,5 MB.

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

66.5% 66.5% Coverage
4.7% 4.7% Duplication