search

MehmetAzizYirik / MAYGEN

MAYGEN is an open source chemical structure generator based on the orderly graph generation method.
MIT License
47 stars 15 forks source link

Fixed sonarcloud warnings. #80

Closed javadev closed 3 years ago

javadev commented 3 years ago

@MehmetAzizYirik I prepared some sonarcloud warnings fixes. It may be useful.

codecov-commenter commented 3 years ago

Codecov Report

Merging #80 (871329a) into main (349511f) will increase coverage by 5.05%. The diff coverage is 69.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #80      +/-   ##
============================================
+ Coverage     69.62%   74.67%   +5.05%     
- Complexity      397      455      +58     
============================================
  Files             4        4              
  Lines          1794     1844      +50     
  Branches        402      406       +4     
============================================
+ Hits           1249     1377     +128     
+ Misses          475      373     -102     
- Partials         70       94      +24
Impacted Files Coverage Δ
src/main/java/maygen/MAYGEN.java 76.61% <62.06%> (+2.58%) :arrow_up:
src/main/java/maygen/Generation.java 87.17% <72.72%> (+12.17%) :arrow_up:
src/main/java/maygen/HydrogenDistributor.java 100.00% <100.00%> (ø)
src/main/java/maygen/SDFWriter.java 30.32% <0.00%> (+30.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 349511f...871329a. Read the comment docs.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.0% 83.0% Coverage
0.0% 0.0% Duplication