Change player id uint - Githubissues

MeikelLP / quantum-core-x

Metin2 open source server implementation

https://meikellp.github.io/quantum-core-x/

Mozilla Public License 2.0

35 stars 9 forks source link

Change player id uint #133

Closed MeikelLP closed 5 months ago

MeikelLP commented 5 months ago

In #125 I found that some client APIs require a valid uint ID for tracking players. This is not the instance ID of an entity (VID) but a database ID instead. Thus I'm changing the ID from a Guid to uint.

This is a breaking change. Please clean your db first. No data is migrated or restored.
A default admin player with operator group is created

Question:

Should I do the same with item ID too? Because this might happen there too

WoozChucky commented 5 months ago

I believe at this stage (still working on first milestone), it is okay to do these breaking changes. While we're unsure if for example the item's id will be needed in the client in the future, I believe we can leave as it is and cross that bridge when we get there (if it happens, should still be in 1st milestone)

sonarcloud[bot] commented 5 months ago

Quality Gate failed

Failed conditions
67.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud