MeikelLP / quantum-core-x

Metin2 open source server implementation
https://meikellp.github.io/quantum-core-x/
Mozilla Public License 2.0
35 stars 9 forks source link

Implement skills #146

Closed WoozChucky closed 4 months ago

WoozChucky commented 4 months ago

This PR is the initial work on in-game skills.

The goal currently is for players to be able to select their job/skillgroup, assign skill points and be able to level them. The skills can be used in game, although no effect/damage is implemented.

Implemented skill group choice

Implemented skills level up

Disclaimer: The database migrations had to be reset, so you will loose your working db data. (Unless someone is willing to give me a hand generating a new migration. I tried multiple methods but it seems that the previous migration CharacterPlayTime has an issue and removing that migration or adding one on top of that fails. Tried all the providers, all fail with the same problem so my guess is it not a provider issue but rather a Migration + EF issue. Just not sure why it happened 👎)

MeikelLP commented 4 months ago

I tested it a little and it works fine. Even if we still find some bugs it's feasible for now 👍

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
40.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud