search

MeikelLP / quantum-core-x

Metin2 open source server implementation
https://meikellp.github.io/quantum-core-x/
Mozilla Public License 2.0
35 stars 9 forks source link

fix the registration of command handlers #147

Closed bogdanstanciu99 closed 4 months ago

bogdanstanciu99 commented 4 months ago

The fact that CommandManager was moved to a new assembly resulted in the "types" list being empty here.

image

This happens when initializing the CommandManager from the Game assembly, where all the command handlers are.

WoozChucky commented 4 months ago

Also done in #146 at https://github.com/MeikelLP/quantum-core-x/pull/146/files#diff-3e2566998c07fb07bd03ab9c1f866a3d9fccaaf8d24c27db363fa245bf6e4a42R121.

Can merge yours since its exactly the same fix we both did, and i'll update my pr once this gets merged.

Approved 👍