search

MeikelLP / quantum-core-x

Metin2 open source server implementation
https://meikellp.github.io/quantum-core-x/
Mozilla Public License 2.0
42 stars 9 forks source link

Remove Kaitai Struct Compiler #160

Closed MeikelLP closed 1 month ago

MeikelLP commented 1 month ago

External application (Java) increases complexity + dependencies on the dev / build machine

The tool is only used to load mob_proto and item_proto

Functionality verified by tests. Now using BinarySerializer - no build step required. Configuration via attributes on the POCOs

MeikelLP commented 1 month ago

Code-wise looks good. Besides the tests did you spin up a dev server without issues?

I forgot to test to spawn in new items. Item loading works, but there was a DI issue. Fixed it too.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint