search

MeikelLP / quantum-core-x

Metin2 open source server implementation
https://meikellp.github.io/quantum-core-x/
Mozilla Public License 2.0
35 stars 9 forks source link

Implement "Already Logged In" and Refactor Redis #161

Closed uutkukorkmaz closed 1 week ago

uutkukorkmaz commented 3 weeks ago

Hey everyone! 👋

This is my first contribution to this awesome project, I'm excited to dive in and I believe there's many to come 😄

After setting up and exploring the project, I noticed that when attempting to log in from a second client, there was no restriction preventing multiple logins for the same account. For example, I was able to log into the "admin" account from two different clients and control two different characters on the same account simultaneously.

To address this, I’ve implemented a fix that displays a "your account is already connected" message (which is ALREADY status for failed login) when a second login attempt is made from another client while the same account is already active. This change will help prevent confusion and maintain the integrity of player sessions by enforcing single-client access per account.

I’m looking forward to hearing your thoughts, and I’m excited to continue contributing to the growth of this project. 🚀

Here's the screenshot:

image

MeikelLP commented 2 weeks ago

Next time I'd like to split the refactoring and the feature :)

uutkukorkmaz commented 2 weeks ago

Next time I'd like to split the refactoring and the feature :)

Yeah I know, right :) I did it in kind of a hurry but for the next time make sure keeping things minimal

MeikelLP commented 2 weeks ago

Some tests are failing. Otherwise PR lgtm

Also if possible can you change the first commit messages to the new commit message guideline? I see you used it in your latest commits already but if it's not to big of a hassle we can maybe improve old messages before merging :) if not that's fine!

uutkukorkmaz commented 1 week ago

I'm afraid there is too many commits to update :) If it's fine I'll keep them as is. You can merge whenever you like

MeikelLP commented 1 week ago

The Tests are still failing 👀

MeikelLP commented 1 week ago

5 tests are failing in Game.Tests - some cache related tests. You may need to update those too.

uutkukorkmaz commented 1 week ago

I fixed the tests but commit checks are failing 👀 @MeikelLP

MeikelLP commented 1 week ago

I fixed the tests but commit checks are failing 👀 @MeikelLP

Yep it's the PR commit checker - I have to look into it. Not your fault