MeikelLP / quantum-core-x

Metin2 open source server implementation
https://meikellp.github.io/quantum-core-x/
Mozilla Public License 2.0
42 stars 9 forks source link

feat(game): Implement IFileProvider #199

Closed MeikelLP closed 1 week ago

MeikelLP commented 2 weeks ago

Refactored code to use IFileProvider instead of raw System.IO (i.e. File.ReadAllText).

The IFileProvider is used in ASP.NET Core to load static files from the wwwroot but can be used more generically as well.

Specifically the app will not set the ContentRoot (used by the PhysicalFileProvider) to data next to the apps executable OR (in development) next to the Game.csproj (checks if any csproj is in a specific parent dir). This will significantly improve developer experience as we no longer need to worry whether the bin folder can be deleted (clean).

Main changes

Breaking changes

Additional changes

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud