Closed MeikelLP closed 11 months ago
Impressive work, except for the two small minor changes it looks good 👍
Thanks for your feedback
Very impressive improvements indeed 💪 If you manage to clean up the calls to Task.Wait() and Task.Result that for now seem to not be easily avoidable it would be even more impressive ;)
Also have you considered adding some documentation here and there? Maybe just on class level. For me as an outsider it was quite hard to understand what the purpose of a SpawnGroup or the AtlasProvider is. Some documentation would make this at-a-glance informantion :)
Kudos, SonarCloud Quality Gate passed!
This PR depends on #21
I created benchmarks in the
Game.Benchmarks
project. These can be executed on the master branch as well (some minor adjustments needed). These benchmark results show massive improvements in tick time and allocations.Before
After
Changes
The following changes where made:
PlayerEntity.GetPoint
by preloading values and just returning the current state. Weapon damage may change if the item is switched. An event has been created in theInventory
class