MeikelLP / quantum-core-x

Metin2 open source server implementation
https://meikellp.github.io/quantum-core-x/
Mozilla Public License 2.0
35 stars 9 forks source link

Creating character result into SQL error #26

Closed NoFr1ends closed 11 months ago

NoFr1ends commented 11 months ago

https://github.com/MeikelLP/quantum-core-x/blob/4c894b56df77ec68b020a1c4af27f084621c38d7/Executables/Game/PacketHandlers/Select/CreateCharacterHandler.cs#L60 the name from the client is copied 1:1 into the database entity, the received name from the client is a string with \0 byte characters at the end. We should probably truncate everything after the first \0 character when parsing packets.