Implement Drops

[MeikelLP]

TODOs

• [x] Load legacy drop info files

  • [x] common_drop_item.txt
  • [x] etc_drop_item.txt + from mob_proto
  • [x] mob_drop_item.txt
  • [x] drop_item_group.txt <-- information for this kind of drops is actually contained in mob_drop_item.txt

• [x] Drop items when killing mobs

• [x] Calculate drop chance based on level

• [x] Ownership

  • [x] Show ownership
  • [x] Enforce ownership

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

0.0% Coverage
0.0% Duplication

[MeikelLP]

@WoozChucky is this done? If yes I can merge it for u (overriding sonar rule)

[WoozChucky]

I think at this stage, we either need to implement skills, quests and riding to implement these specific drops differently, or merge it like this and when we implement said systems, it needs to be coded in the drops logic.

Sent from Outlook for iOShttps://aka.ms/o0ukef

---

From: Meikel Philipp @.> Sent: Thursday, May 16, 2024 3:01:13 PM To: MeikelLP/quantum-core-x @.> Cc: Nuno Silva @.>; Mention @.> Subject: Re: [MeikelLP/quantum-core-x] Implement Drops (PR #35)

@WoozChuckyhttps://github.com/WoozChucky is this done? If yes I can merge it for u (overriding sonar rule)

— Reply to this email directly, view it on GitHubhttps://github.com/MeikelLP/quantum-core-x/pull/35#issuecomment-2115334608, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOD5FHFPMSAMRDD27XGMBDZCS32TAVCNFSM6AAAAAA6TPMZF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGMZTINRQHA. You are receiving this because you were mentioned.Message ID: @.***>

[sonarcloud[bot]]

Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[MeikelLP]

@WoozChucky I think it's fine in the current state. More features will be added as dependencies get implemented. Feel free to write these dependencies down somehow (roadmap?)