MeilleursAgents / terraform-provider-ansiblevault

Read ansible vault from Terraform
https://registry.terraform.io/providers/MeilleursAgents/ansiblevault/latest
MIT License
76 stars 19 forks source link

Closes #78 - Simplified value lookup and removed case insensitivity. #79

Closed rvben closed 4 years ago

rvben commented 4 years ago

Before creating my pull-request, I ensure:

In order to validate the pull request, I do:

codecov[bot] commented 4 years ago

Codecov Report

Merging #79 into master will decrease coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   93.37%   93.33%   -0.04%     
==========================================
  Files           5        5              
  Lines         181      180       -1     
==========================================
- Hits          169      168       -1     
  Misses          8        8              
  Partials        4        4              
Impacted Files Coverage Δ
pkg/vault/vault.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fce7352...7d3582f. Read the comment docs.

rvben commented 4 years ago

@ViBiOh, I just removed the unused variables from the vault.

ViBiOh commented 4 years ago

@ViBiOh, I just removed the unused variables from the vault.

Nice, thank you again for improving the provider :)

You still have an issue with signing your commit, do you need or want help ? If you have trouble, I think I can co-author your commit and sign it with my PGP key

rvben commented 4 years ago

I signed both the commit in both PRs. It should be alright now.