search

MeirSylman / MyAssignments

0 stars 0 forks source link

Final project review_Roi Siegelman #3

Open roisiegelman opened 3 days ago

roisiegelman commented 3 days ago

Hi Meir, I've added a link to my final project and will like to get your input. https://github.com/roisiegelman/NSD1-in-Breast-Cancer

@szabgab

MeirSylman commented 3 days ago

Hi Roi, Your project looks very interesting and well exlpained.

Few comments: -I think there is a typo in the second paragraph " classification6. Of the". -I couldn't find the pytest test_data_processing.py file.

Thanks for sharing your work with me

roisiegelman commented 3 days ago

Hi Meir, I've fixed the typo and uploaded the test_data_processing.py file.

regarding the error, did you install all the required packages? o run this script, you need to have the following Python libraries installed:

pandas matplotlib numpy lifelines gseapy You can install these libraries using pip:

pip install pandas matplotlib numpy lifelines gseapy I've tried to run and it worked.

maybe try to clone my repository:

git clone https://github.com/roisiegelman/NSD1-in-Breast-Cancer NSD1-in-Breast-Cancer

MeirSylman commented 2 days ago

You right, I skipped the packages installation. Now I made it, but got this error for pytest test_data_analysis.py:

FAILED test_data_analysis.py::test_run_gsea - ImportError: Missing optional dependency 'openpyxl'. Use pip or conda to install openpyxl. FAILED test_data_analysis.py::test_plot_kaplan_meier - AttributeError: 'Legend' object has no attribute 'legendHandles'. Did you mean: 'legend_handles'? ============================================= 2 failed, 5 passed in 6.83s =============================================

szabgab commented 2 days ago

you need to have the following Python libraries installed:

pandas matplotlib numpy lifelines gseapy You can install these libraries using pip:

that should be pip install -r requirements.txt