Siege of Boralus wrong count

[xIGBClutchIx]

In the BFA dungeon Siege of Boralus the count is wrong due to one of the bosses being only able to be killed by the opposite faction. Sergeant Bainbridge (Horde) or Chopper Redhook (Alliance). Intended should be 4/4 but instead saids 4/5.

[Meivyn]

Thanks for your report. I'll fix this in the next commit.

[Meivyn]

I don't have access to Siege of Boralus yet. Can you do a /dump GetInstanceInfo() while in the instance and give me the exact string at [1] please?

[xIGBClutchIx]

Yep here you go

[1]="Siege of Boralus", 

[Meivyn]

Thanks. Should be fixed in next release. Just do a /reload.

[xIGBClutchIx]

That looks to have fixed the icon but now when I highlight over it the final boss is missing in the tooltip. I assume looking at your fix it just scans the first 4 bosses but technically there is 5 bosses and wow just does not let you see one and kill it because of opposite faction.

[Meivyn]

If you have cleared the instance, it should display the 4 bosses you had killed. Can you give me a screenshot of your issue?

[xIGBClutchIx]

A before and after of the fix.

Before latest version:

After latest version:

What happens is when you put the maxBosses to 4 it can't get to the last one because it just loops to 4 and the last boss is 5. https://github.com/Meivyn/EncounterJournalSavedInstances/blob/master/EncounterJournalSavedInstances.lua#L303 The only way I thought of fixing it is putting in special code if a person is alliance or horde.

[Meivyn]

I can't test it myself so I'll need your help to try something. Try to replace the loop by this:

local b = 1
while GetSavedInstanceEncounterInfo(i, b) do
    local bossName, _, isKilled = GetSavedInstanceEncounterInfo(i, b)
    table.insert(bosses, {
        name = bossName,
        isKilled = isKilled
    })
    b = b + 1
end

[xIGBClutchIx]

That looks to have worked.

[Meivyn]

Fixed in 5b77394c26a431256e72ff57d5952ad662a276bc.