Meivyn / AdventureGuideLockouts

A fork and continuation of Adventure Guide Saved Instances WoW add-on.
https://wow.curseforge.com/projects/adventure-guide-lockouts
GNU General Public License v3.0
9 stars 2 forks source link

Freehold Mythic is not showing #6

Closed Mipsenx closed 6 years ago

Mipsenx commented 6 years ago

Freehold Mythic is not showing, not sure if its because i also did one on m+ Was Alliance EU 2018-09-15 2018-09-15 1

kurathor commented 6 years ago

Same issue here, Freehold does not show up. In 1.1.9 it did.

Meivyn commented 6 years ago

Thanks for your report, currently looking into it.

I changed how the addon assigns flags to EJ tiles in v1.2.0, in a way that it shouldn't need locales anymore and should work on all clients. I'll see on my side if it's working, so I'll know if that's a client issue or not. If not I'll start debugging. If it's related to the client, I'll need more info from you.

Meivyn commented 6 years ago

Seems like it's not a client issue. I'll need some time to figure it out.

kurathor commented 6 years ago

I found the issue. When you iterate over your instanceData array to replace the instanceID then the Freehold ID get replaced from 1754 to 1001 and then again via Scarlet Halls from 1001 to 311. Changing

for k, v in pairs(instancesData) do
    if instanceID == k then
        instanceID = v
    end
end

to

for k, v in pairs(instancesData) do
    if instanceID == k then
        instanceID = v
        break
    end
end

fixed the issue for me.

Meivyn commented 6 years ago

Yes, I noticed it, didn't know how to fix it though, I just woke up. But I found a better way to do it.

Thanks for your contribution.

Meivyn commented 6 years ago

Fixed in 44b10c8ad7b3fdd11d259922c87db2586c359ce5.