MelGrubb / BuilderGenerator

A source-generator-based implementation of the Builder pattern
https://melgrubb.github.io/BuilderGenerator/
MIT License
36 stars 8 forks source link

What version is the latest stable? #6

Closed dinotom closed 2 years ago

dinotom commented 2 years ago

On Installing the package with either the console or package manager results in version 0.5 being installed. But with that version installed ( at least in VS 2022 RC1) the attribute [GenerateBuilder] is NOT recognized.

I went back to 1.5 and decorated three classes in my Domain project with the [GenerateBuilder] attribute (which is recognized with that version installed) but on Build, nothing is generated

dinotom commented 2 years ago

BTW... Great course and presentation on automated testing on Pluralsight. You should do another.

MelGrubb commented 2 years ago

Well, so much for notifications working. Sorry I didn't see this earlier. I would love to do another course, specifically one on source generators. We'll see what they say. Let me look into your other question. I sort of stopped working on this while I waited for the tooling to stabilize a little more, but I should be able to get back to it soon. It does appear that NuGet.org is still serving v0.5. Let me see if I can get v1.1 up there for you.

MelGrubb commented 2 years ago

I just pushed v1.1.0 to NuGet. I think what happened here is a simple version numbering problem. My publish script was still using v0.5.0. The contents may have been correct though. When I last worked on this, I was trying to get GitHub actions in place to do the publishing for me, and I think that's where it all went wrong. Anyway, I manually pushed v1.1.0 just now, so you should be all caught up. I'm about to dive back into this as my primary side project away from work in order to see whether Visual Studio's support has gotten any better in the last few months. That was the major stumbling block at the time.

dinotom commented 2 years ago

I’ll try it later when I’m home thank you for doing it

Get Outlook for iOShttps://aka.ms/o0ukef


From: Mel Grubb @.> Sent: Sunday, October 31, 2021 11:18:21 AM To: MelGrubb/BuilderGenerator @.> Cc: Tom Donino @.>; Author @.> Subject: Re: [MelGrubb/BuilderGenerator] What version is the latest stable? (#6)

I just pushed v1.1.0 to NuGet. I think what happened here is a simple version numbering problem. My publish script was still using v0.5.0. The contents may have been correct though. When I last worked on this, I was trying to get GitHub actions in place to do the publishing for me, and I think that's where it all went wrong. Anyway, I manually pushed v1.1.0 just now, so you should be all caught up. I'm about to dive back into this as my primary side project away from work in order to see whether Visual Studio's support has gotten any better in the last few months. That was the major stumbling block at the time.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMelGrubb%2FBuilderGenerator%2Fissues%2F6%23issuecomment-955718903&data=04%7C01%7C%7C939162d1a301402638e308d99c81ad1a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712903027071625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tuxY0yMJtR1JY0dKjLYKhKb1vO8mPS4X%2FQ4U%2BYkyFDw%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABKTG53UCYPMYHWSRFOYCILUJVM33ANCNFSM5ETQTUSA&data=04%7C01%7C%7C939162d1a301402638e308d99c81ad1a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712903027071625%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=LK4P%2F2x15oYPhPQ9d%2BtL643FqBVHfCp5BGOU8vLUiA4%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C939162d1a301402638e308d99c81ad1a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712903027081574%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=oXBfEBpZLmkBSOkz%2BmsBslNGskkexzOAVenrcuyiR7o%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C939162d1a301402638e308d99c81ad1a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637712903027081574%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=oglPL8LurY6NoKwIDP7u0Hu%2FZ25%2Fd6Jf5mMJDiUFJtc%3D&reserved=0.

MelGrubb commented 2 years ago

I could only get it to work locally, but the version coming from NuGet.org was giving me errors. I've de-listed it and re-opened this issue until I can work out what's happened and get a stable version up that I'm happy with. For now, consider 0.5.0 to be the latest stable version. It works, without some of the flexibility I was planning. I just need to figure out what I broke in the last set of updates and get it all back on straight, then I'll be back to getting it in line with where the roadmap said it should be.

MelGrubb commented 2 years ago

Okay, got it. I burned a couple numbers in the process, so I'm having to call it v1.2.0 now. NuGet won't let you reuse numbers... ever, and I made some actual changes along the way, so we'll call it 1.2 and just change the roadmap to move some things to v1.5. Tests are passing again, so I'm re-closing the issue.