search

Melapress / admin-notices-manager

Admin notices manager is a WordPress plugin that allows you to better manage the admin notices in the WordPress dashboard so you read them at your own convenience and never miss an important message.
https://www.wpwhitesecurity.com/wordpress-plugins/admin-notices-manager/
Other
0 stars 0 forks source link

Issue 3 create a better ux for first time users #6

Closed martinkrcho closed 4 years ago

martinkrcho commented 4 years ago

Fix for https://github.com/WPWhiteSecurity/admin-notices-manager/issues/3.

DannyWPWS commented 4 years ago

@martinkrcho I followed the steps here to create the zip to test this, but when activating the plugin (via the zip) im getting this

[20-Aug-2020 12:50:29 UTC] PHP Notice:  Undefined index: pointerClass in D:\Local Sites\admin-notices\app\public\wp-content\plugins\wp-admin-notices-manager-1.0.0-2020-08-20_13-35\includes\classes\PointersManager.php on line 60
[20-Aug-2020 12:50:29 UTC] PHP Stack trace:
[20-Aug-2020 12:50:29 UTC] PHP   1. {main}() D:\Local Sites\admin-notices\app\public\wp-admin\admin-ajax.php:0
[20-Aug-2020 12:50:29 UTC] PHP   2. do_action() D:\Local Sites\admin-notices\app\public\wp-admin\admin-ajax.php:45
[20-Aug-2020 12:50:29 UTC] PHP   3. WP_Hook->do_action() D:\Local Sites\admin-notices\app\public\wp-includes\plugin.php:478
[20-Aug-2020 12:50:29 UTC] PHP   4. WP_Hook->apply_filters() D:\Local Sites\admin-notices\app\public\wp-includes\class-wp-hook.php:311
[20-Aug-2020 12:50:29 UTC] PHP   5. AdminNoticesManager\Pointer->register_pointers() D:\Local Sites\admin-notices\app\public\wp-includes\class-wp-hook.php:287
[20-Aug-2020 12:50:29 UTC] PHP   6. AdminNoticesManager\PointersManager->add_pointer() D:\Local Sites\admin-notices\app\public\wp-content\plugins\wp-admin-notices-manager-1.0.0-2020-08-20_13-35\includes\classes\Pointer.php:16

Ill try again however

DannyWPWS commented 4 years ago

@martinkrcho My last commit fixes the error (just adding pointerClass so its known in the array for a pointers options) but I cant see anything when I activate, ill talk to you about this PR in the morning when your back :)