Melapress / admin-notices-manager

Admin notices manager is a WordPress plugin that allows you to better manage the admin notices in the WordPress dashboard so you read them at your own convenience and never miss an important message.
https://www.wpwhitesecurity.com/wordpress-plugins/admin-notices-manager/
Other
0 stars 0 forks source link

Small issue with notifications '1' showing up instead of none #78

Closed jwjsystem closed 5 months ago

jwjsystem commented 1 year ago

Not sure if this is indeed a feature (to have that '1' for design purposes to indicate a notification pannel), or if it should be removed?

I reproduced this after hiding all the list of notifications. I was expecting that '1' though to go away.

w

DannyWPWS commented 1 year ago

@jwjsystem

Please check this again with the latest build

I was unable to reproduce a problem (the number went to 0) here so if you can, please provide steps I can follow so I can do the same, thanks

DannyWPWS commented 1 year ago

Current behaviour https://i.gyazo.com/c97386348bb042a0a91ceb16272f7a1c.mp4

jwjsystem commented 1 year ago

@DannyWPWS I will give this one a go again when the build is ready - I might have omitted some extra details - I came across this with other plugins installed (such as Elementor, Loco Translate - the ones for which users have reported some issues), and that's why most probaby this occured, because of interactions (so it was NOT a fresh/vanilla setup).

I will come back if I manage to reproduce again after re-testing on single and multi .

Thank you!

jwjsystem commented 1 year ago

@DannyWPWS Update:

I managed to reproduce again on this test site - the notification number is displayed as "3" for example, but when opening the tab there are "2" displayed.

https://site4.lucian.wpws.org/wp-admin/update-core.php

The counting problem can be seen sitewide in lots of places - the notification is not actually showing the correct number

DannyWPWS commented 1 year ago

Noting some details as this is not globally an issue - the count changes based on screen

https://site4.lucian.wpws.org/wp-admin/update-core.php shows 3 in the number, but 2 notices, wheras https://site4.lucian.wpws.org/wp-admin/plugins.php displays 2 in the number which is correct

DannyWPWS commented 1 year ago

/cib

create-issue-branch[bot] commented 1 year ago

Branch issue-78-Small_issue_with_notifications_1_showing_up_instead_of_none created!