search

Meldexun / EntityCulling

Minecraft Mod: Skip rendering of hidden entities.
26 stars 2 forks source link

[Crash] Incompatibility with Valkyrien Skies #46

Closed gatoborrachon closed 2 years ago

gatoborrachon commented 2 years ago

Describe the bug When you try to assemble a Valkyrien Skies' Ship with EntityCulling installed, you will get a crash

To Reproduce Steps to reproduce the behavior:

  1. Build a simple ship in the air using any block you want 2021-10-23_17 55 31

  2. Place the blocks called "Physics Infuser" and "Captain's Chair" over the ship, and then, put the item called "Physics Core" inside the "Physics Infuser" 1.- Physics Infuser and Captain's Chair 2021-10-23_17 55 45

2.- "Physics Core" inside the "Physics Infuser" 2021-10-23_17 55 57

  1. Try to Assemble this ship with the "Physics Infuser" by clicking the "Assemble Ship" Buttom 2021-10-23_17 56 01

  2. See crash

Expected behavior No crash

Versions Entity Culling: 4.2.5 Forge: 14.23.5.2860 Minecraft: 1.12.2 Valkyrien Skies Core: 1.1.7 Valkyrien Skies World: 1.0.0 Valkyrien Skies Control: 1.1.1

Other Crash report (upload as a file): crash-2021-12-24_20.05.47-client.txt Latest log (upload as a file): latest.log Singleplayer/Multiplayer: Singleplayer Other mods (that are necessary to produce the bug): Valkyrien Skies Core, Valkyrien Skies World and Valkyrien Skies Control Other mods (that are also installed): Nothing more Additional Notes: 1.- Downgrading to EntityCulling 4.1.5 fixes the issue, if i use EntityCulling 4.2.1 i get the same crash 2.- I know that messing with Valkyrien Skies might be a pain in the rear, so if the issue has no (easy) fix from your side, no problem, i will continue using 4.1.5, thanks anyways

Meldexun commented 2 years ago

Fixed in v1.12.2-5.0.1