Meldexun / RenderLib

7 stars 1 forks source link

Renderlib has a conflict with tick dynamic, invisible Chest #29

Closed quentin452 closed 1 year ago

quentin452 commented 1 year ago

Disclaimer: If applicable please set the openGLDebugOutput -> enabled config option from RenderLib to true and try to reproduce the issue. (there is no log when i enabling it)

Describe the bug A clear and concise description of what the bug is. When tick dynamic + renderlib is enabled renderlib make invisible chest and other tile entities

Reproducibility Please try to reproduce the issue with as few other mods as possible. Then check one of the following checkboxes according to your results. To check a checkbox replace the space between the square brackets with an x (like this [x]) or create the issue and check the checkbox by clicking on it.

To Reproduce Steps to reproduce the behavior. Please keep in mind that I most likely don't know how other mods involved in this issue work. Thus terms like "Go to dimension X" should be explained in more detail because I probably don't know how to do that.

  1. Launch world
  2. Place chest or an enchant table
  3. See its invisible

Screenshots/Videos If applicable, add screenshots or videos to help explain your problem. 2023-08-11_20 57 12

Versions RenderLib: 1.3.2 Forge: 14.23.5.2860 Minecraft: 1.12.2 Other mods (necessary to reproduce the bug): !mixinbooter-8.3 TickDynamic-1.12.2-1.0.3

Hardware CPU: I5 10400F RAM: 32GB DDR4 GPU: RTX 3060 VRAM: 12GB

Log File latest.log

Desenrrollado commented 1 year ago

I'd definitely like to to see this bug fixed as well. As Quentin stated this affects chests, and various other blocks.

With RenderLib x Tick Dynamic. Screenshot_1 Screenshot_2 Screenshot_3 Screenshot_4

Without: Screenshot_5 Screenshot_6

Mods: Mods

Sidenote: Sorry for the disorganized list. I've also tried these on a new instance with less then the provided mods. Same thing happens.

Meldexun commented 1 year ago

The class transformer of Tick Dynamic just loads various classes that are not excluded from being transformed. This can cause issues like this. I might be able to fix this on my end but that would require a lot of work and then this would still affect a lot of other mods (mine and others). So I will probably not fix this.

Though Tick Dynamic's license is MIT. So if someone is willing to update Tick Dynamic then I can help them to fix this issue properly. (I just don't want to maintain that a fork of Tick Dynamic myself)

quentin452 commented 1 year ago

i have a fork of it , so if someone make a pull request i will release it

quentin452 commented 1 year ago

issue fixed in TickDynamic-1.12.2-1.0.5

Devilswarchild commented 1 month ago

issue fixed in TickDynamic-1.12.2-1.0.5

I dont see this file available on curseforge

editL nvm I see it now