MelihAltintas / vue3-openlayers

Web map Vue 3.x components with the power of OpenLayers
https://vue3openlayers.netlify.app/
MIT License
629 stars 120 forks source link

OlSourceTianDiTu should be OlSourceTianditu is better #281

Closed shiftonetothree closed 6 months ago

shiftonetothree commented 7 months ago

Describe the bug OlSourceTianDiTu is not for vue template , it's work for . OlSourceTianditu will be right for ;

Affected version(s)

├── ol-contextmenu@5.3.0
├── ol-ext@4.0.12
├── ol@8.2.0
├── vue@3.3.9
└── vue3-openlayers@3.1.0

To Reproduce Steps to reproduce the behavior:

Expected behavior typescript works well

Screenshots 企业微信截图_5bc2f154-d395-4b63-abed-8ebe6ce0ded6

企业微信截图_8141f197-7d20-473c-8195-432a07cefc41

d-koppenhagen commented 7 months ago

okay, I got what you mean I think. So correct would be ol-source-tian-di-tu and not ol-source-tianditu? Currently it's explicitely named as ol-source-tianditu. I think Tianditu is the correct spelling isn't it (at least Wikipedia says it: https://en.wikipedia.org/wiki/Tianditu). So the Component should be renamed.

d-koppenhagen commented 7 months ago

That's what ChatGPT says:

The correct term in English would typically be "Tianditu." While "Tian Di Tu" and "Tian-Di-Tu" are variations of the same term, the Pinyin romanization system used for Mandarin Chinese usually represents it as "Tianditu" without spaces or hyphens. Pinyin is the official romanization system for Standard Mandarin in mainland China.

shiftonetothree commented 5 months ago

That's what ChatGPT says:

The correct term in English would typically be "Tianditu." While "Tian Di Tu" and "Tian-Di-Tu" are variations of the same term, the Pinyin romanization system used for Mandarin Chinese usually represents it as "Tianditu" without spaces or hyphens. Pinyin is the official romanization system for Standard Mandarin in mainland China.

Thanks, Tianditu good for me in typescript.