MelihAltintas / vue3-openlayers

Web map Vue 3.x components with the power of OpenLayers
https://vue3openlayers.netlify.app/
MIT License
680 stars 126 forks source link

feat(ol-style-text): added fill and stroke props #283

Closed chady closed 10 months ago

chady commented 10 months ago

Thank you for the awesome library, it has saved me a ton of work. I've been trying to style some labels over map markers, and realized that I was unable to set the color of the text nor the stroke.

Description

Upon further digging, I came across this PR so I followed the same template used there and just added the missing props.

Motivation and Context

These two props are important to style text, and OlStyleText already implements those.

How Has This Been Tested?

I tested this by pointing my project's npm to my local copy and tested the color and stroke modifications according to usage.

Screenshots (if appropriate):

Screenshot 2023-11-30 at 9 10 45 PM Screenshot 2023-11-30 at 9 11 39 PM Screenshot 2023-11-30 at 9 12 31 PM

Types of Changes

Checklist:

If you added a new component feature (layer, geom, source, etc.), please be sure to update the documentation:

netlify[bot] commented 10 months ago

Deploy Preview for vue3openlayers ready!

Name Link
Latest commit 3030bfc3c917cbb1bd056ffd8a44141b3ba8b625
Latest deploy log https://app.netlify.com/sites/vue3openlayers/deploys/656941692920320008403bc5
Deploy Preview https://deploy-preview-283--vue3openlayers.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.