Closed christophfriedrich closed 3 months ago
Name | Link |
---|---|
Latest commit | 5f24fb9854bc0cbc262cc9123c92b226c6ee07c1 |
Latest deploy log | https://app.netlify.com/sites/vue3openlayers/deploys/65f17da5882ec90008af13b2 |
Deploy Preview | https://deploy-preview-311--vue3openlayers.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Description
Upgraded the
ol-contextmenu
dependency to v5.4.0 (was v5.3.0 previously).Motivation and Context
Currently, setting up a project with the peerDependencies as listed in the README results in a dependency conflict because
ol=^9.0.0
is specified but ol-contextmenu 5.3.0 explicitly statesol<=8.x
, which is fixed in the 5.4.0 version that @d-koppenhagen submitted and has since been released. Therefore theoverrides
workaround in the package.json is no longer necessary.Edit: I just realised there was already an issue for this: #308
How Has This Been Tested?
Honestly I haven't tested this at all, but as the upstream change doesn't change anything than this very thing, it should be fine.™️
I hope I did everything correctly as this is the first time I commit to this project. I'm very happy to learn about anything I missed. My first intuition was to open another issue for it, but then I thought I could as well plunge forward and fix it myself :)
Types of Changes
Checklist:
If you added a new component feature (layer, geom, source, etc.), please be sure to update the documentation:
output.globals
invite.config.ts
src/demos/<Component>Demo.vue
docs/componentsguide/<Category>/<Feature>/index.md
containing the Demo and documentation for the componentdocs/.vitepress/config.ts