search

Melkeydev / astrostation

https://astrostation.me
MIT License
209 stars 42 forks source link

"Stop" -> "Pause" on timer button to reduce confusion #222

Closed Samathingamajig closed 1 year ago

Samathingamajig commented 1 year ago

Generally, countdown timers say "pause" to let the user know that it can be resumed later, as "stop" is generally a final action.

Ideally, there would be some kind of state to track "Start" -> "Pause" \<-> "Resume", but I didn't want add complexity. If others think this would be good, it's only adding a boolean useState and slightly complicating the displaying section with nested ternary.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
astrostation ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 3:13PM (UTC)
royanger commented 1 year ago

Hey Sam, can you add your github user name to contributors.yml? Thanks

Samathingamajig commented 1 year ago

@royanger I've added my name to the contributors list

royanger commented 1 year ago

Thanks @Samathingamajig