search

Melkeydev / astrostation

https://astrostation.me
MIT License
209 stars 42 forks source link

Added github button #239

Closed madeleine-patience closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
astrostation ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 4:55AM (UTC)
Melkeydev commented 1 year ago

@madeleine-patience Can you make this commit against staging instead of GH?

madeleine-patience commented 1 year ago

@madeleine-patience Can you make this commit against staging instead of GH?

  • add yourself to the contributors file too!

Both of these are done.

Melkeydev commented 1 year ago

image The image seems to be a bit small. the padding of the button is taking more of the attention than the actual GH logo. Can we increase the size of the GH icon so it fills in more of the real-estate?

madeleine-patience commented 1 year ago

Thank you for the comments, I've updated as you requested, PTAL

madeleine-patience commented 1 year ago

I just had a second look this morning- maybe the buttons should be square.

royanger commented 1 year ago

Hey @madeleine-patience, we noticed that the new component that holds the bottom buttons is missing some left padding. The Donate button is butting up against the edge of the screen. Compare that to the production release to see the difference.

madeleine-patience commented 1 year ago

@royanger padding re-added and @Hacksore I changed the navigate function to an anchor tag instead.