Melkeydev / astrostation

https://astrostation.me
MIT License
209 stars 42 forks source link

TaskTracker Improvements #242

Closed justnat3 closed 1 year ago

justnat3 commented 1 year ago

NOTE: This is not currently linked to an issue.

Description

The motivation behind this patch is to improve the functionality & user experience for Task Tracker

Right Click Context Menu

The Context Menu options are used as a toggle

image

Button & Padding for Settings menu with deleted gone

image

Checklist

The changes presented in this PR are committed by change & not change-set

Is it tested?

This was tested locally, please pull this down and test it yourself as well. :)

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
astrostation ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 4:19AM (UTC)
Hacksore commented 1 year ago

One bug found:

justnat3 commented 1 year ago

@Melkeydev

I do have an issue though, Hacksore pointed out in a call- that the ContextMenu's behavior is a little strange. In the way that the ContextMenu only closes (other than opening another one), when the cursor enters & then exits the ContextMenu. Which isn't desired, ideally it closes when a user clicks somewhere else than the menu, or hit escape.

I thought that I may be able to use a custom hook for that, however I think I would rather gather some guidance on how I may approach that problem.

Really what it may boil down to is an EventListener on mousedown/up and use a ref to that DOM element to check whether or not the user is within the bounds of the element during the click. Then a listener for escape of course.

Let me know what you think 🚀

Cheers, -Nate

justnat3 commented 1 year ago

I do have an issue though, Hacksore pointed out in a call- that the ContextMenu's behavior is a little strange. In the way that the ContextMenu only closes (other than opening another one), when the cursor enters & then exits the ContextMenu. Which isn't desired, ideally it closes when a user clicks somewhere else than the menu, or hit escape.

I thought that I may be able to use a custom hook for that, however I think I would rather gather some guidance on how I may approach that problem.

Really what it may boil down to is an EventListener on mousedown/up and use a ref to that DOM element to check whether or not the user is within the bounds of the element during the click. Then a listener for escape of course.

Let me know what you think 🚀

Cheers, -Nate

So It turns out that my implementation was off-by-one, however with some stackoverflow help this seems to be a more stable than mine!

I think this is ready though. In the future I would love to refactor a part of TaskTracker in order to make the context menu to act more like the system context menu

Also I added some padding to the cancel and okay button in the settings drawer, with color they collide a bit with edges of the settings drawer.

Cheers, -Nate

justnat3 commented 1 year ago

Blunder. Doesn't close when option is clicked on.

Fixing....

Melkeydev commented 1 year ago

This looks dope. I am looking at your vercel deployment here https://astrostation-git-fork-justnat3-new-tasks-patch-melkeyoss.vercel.app/ and one nit i see in functionality is that when the task is set as complete, and you try to track again, it does not change.

justnat3 commented 1 year ago

This looks dope. I am looking at your vercel deployment here https://astrostation-git-fork-justnat3-new-tasks-patch-melkeyoss.vercel.app/ and one nit i see in functionality is that when the task is set as complete, and you try to track again, it does not change.

good to go :)