Melkeydev / astrostation

https://astrostation.me
MIT License
209 stars 42 forks source link

Add custom background color #243

Closed Hacksore closed 1 year ago

Hacksore commented 1 year ago

Add a new background to just have a solid black color.

Please add a :shipit: @Melkeydev when you get some time to review.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astrostation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 0:56am
Melkeydev commented 1 year ago

@Hacksore you got some conflicts!

Hacksore commented 1 year ago

I scuffed my rebase, please standby while I sort it out!

eraychumak commented 1 year ago

I think the City background should be the default background by the way, it's way more immersive and fits the 'vibes' of the app.

Instead of adding Black as a background color, why don't we introduce a Custom color that allows users to pick from a color switcher or inputting a color code?

Hacksore commented 1 year ago

@eraychumak I like that idea will refactor with the changes as follows.

I'll try to get around to this some time this week.

Hacksore commented 1 year ago

Need to sync up about my feature because I'm changing how the background color saves to state which would require a different serialized localstorage value.

It does to me seem like this "might be handled" by the zustand but not to familiar with the overall setup.

{
  "state": {
    "backgroundId": 9,
    "isBackground": 2
  },
  "version": 0
}

Also this the idea i'm thinking of for the color selector with a set of canned colors at least initially.

Melkeydev commented 1 year ago

@Hacksore Let's sink on Discord for this

Hacksore commented 1 year ago

@Melkeydev @royanger @herropaul please take a brief look at the impl and see if it's ok.

Hacksore commented 1 year ago

@Hacksore Let's sink on Discord for this

@Melkeydev Gonna need a sink brother 🙏 image