Melkeydev / astrostation

https://astrostation.me
MIT License
200 stars 42 forks source link

Deleting a Task does not allow you to cancel #246

Closed justnat3 closed 1 month ago

justnat3 commented 1 year ago

image

Even when you click outside or escape the alert box, it still deletes the task.

Cheers, -Nate

justnat3 commented 1 year ago

Ideally this is a modal or an alert that is cancel-able :)

herropaul commented 1 year ago

Ello good sir, I'd like to take this 😎

justnat3 commented 1 year ago

Ello good sir, I'd like to take this 😎

For sure! There's individual modals in the project already. For example, components/TaskTracker/InfoModal you can take inspiration from.

I cant mark you as a contributor for this issue, but I have done a lot to task-tracker consider It yours

herropaul commented 1 year ago

Awesome, im def gonna checkout the infomodal then 👍 . I'll let you know if i have any questions along the way as well

herropaul commented 1 year ago
Screen Shot 2023-03-30 at 6 00 03 PM

I ended up using ur InfoModal as reference @justnat3 haha. Thoughts on the delete modal? Any touch ups or changes you think?

justnat3 commented 1 year ago

I ended up using ur InfoModal as reference @justnat3 haha. Thoughts on the delete modal? Any touch ups or changes you think?

From just looking at it, I personally like the it the overall idea. Good job!

I would love to be able to look at it from a browser(vercel preview) if you want to link this issue to a PR. If you don't feel its quite ready feel free to set the PR as a WIP

herropaul commented 1 year ago

I ended up using ur InfoModal as reference @justnat3 haha. Thoughts on the delete modal? Any touch ups or changes you think?

From just looking at it, I personally like the it the overall idea. Good job!

I would love to be able to look at it from a browser(vercel preview) if you want to link this issue to a PR. If you don't feel its quite ready feel free to set the PR as a WIP

Appreciate it man!

I'll be working on this today, so I don't mind setting up a PR to preview it. I'll make sure its WIP as well

Melkeydev commented 8 months ago

@herropaul Do you have any branches on this? Wondering If i should close this issue due to inactivity

herropaul commented 8 months ago

@Melkeydev I do have a branch on this, how should we got about it? It's still old too so idk if much changed since