Melkeydev / astrostation

https://astrostation.me
MIT License
200 stars 42 forks source link

Issue with Alert() use in astrostation #248

Closed justnat3 closed 1 month ago

justnat3 commented 1 year ago

In this PR https://github.com/MelkeyOSS/astrostation/pull/242 there was the mention of an alert() call ideally being a modal.

Ideally it is a modal, primarily because users are able to disable pop up dialogues(alert) in the browser. You would get one of 2 behaviors.

Not give the user the option to cancel(dialogues disabled) Wouldn't work altogether.

Here are where alert() is called. The vision is to have a modal/toast/alert instead to avoid the issues mentioned in the discussion above.

Where a Toast/Alert can be implemented

Where Modal can be implemented