added persistent playlists with a limit of 5 playlists at once

Melkeydev / astrostation

https://astrostation.me

MIT License

200 stars 42 forks source link

added persistent playlists with a limit of 5 playlists at once #258

Closed cimok2000 closed 10 months ago

cimok2000 commented 1 year ago

Added persistent playlists which save to local storage #253 The playlists dropdown menu is kinda ugly but I can't design anything 💀

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
astrostation	❌ Failed (Inspect)			Apr 18, 2023 3:03pm

herropaul commented 1 year ago

Hey, great work on this btw! I do wanna point out tho we may want have a use case to handle duplicate playlists added. This would prevent showing the same playlist added. Thoughts?

herropaul commented 1 year ago

Another thing I thought would be cool to see is the name of the playlist being shown on the drop down. I think currently it just shows "Playlist" when a new playlist is added?

cimok2000 commented 1 year ago

yeah I can look into adding them! I'll look into duplicate playlists and I'll look into getting the name, the only way I can think of doing the name from Spotify is using their API which will require using an API key, I'll look into it, if there's any other way that you know of doing that I'd love to know, thanks!

royanger commented 1 year ago

Let's avoid the API for now, though we are starting to spec out a backend and can provide that in the future.

cimok2000 commented 1 year ago

Yeah absolutely, should I keep this pull open until the backend us available or make any changes?

Melkeydev commented 1 year ago

@cimok2000 This is a really cool PR.

As mentioned earlier, since we are not gonna to use the Spotify API just yet (until backend is finished). Do you think you can add a feature that lets users name the playlist just so we can avoid the Playlist generic name?
Would it make sense to remove possible duplications?

cimok2000 commented 1 year ago

yeah, I'll make it so duplications are not possible and I'll also make it so that a user can add a unique name for now

Melkeydev commented 1 year ago

@cimok2000 Hey! Any update on this beautiful PR?

royanger commented 1 year ago

@cimok2000 Could you comment in Issue https://github.com/MelkeyOSS/astrostation/issues/253 so we can assign it to you?

cimok2000 commented 1 year ago

hi sorry, I've been super busy this week with unexpected stuff, will get this done soon

cimok2000 commented 1 year ago

this should be the updated version with duplication prevention and allowing a user to set a custom name until the backend is done, this is my first time actually fully committing to a project so I'm not sure if I did things correctly since I couldn't figure out committing to an existing pull request lol