Fixed bugs from adding Youtube widget

Melkeydev / astrostation

https://astrostation.me

MIT License

200 stars 42 forks source link

Fixed bugs from adding Youtube widget #306

Closed mechakin closed 8 months ago

mechakin commented 8 months ago

There were some syntax bugs that came from resolving conflicts, should be fixed now

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
astrostation	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2023 9:09pm

Melkeydev commented 8 months ago

A few comments:

When a person adds the widget through the widget menu - it is automatically toggled to be on. If we add it, can we it toggled off?
when a user adds the YT widget on the side bar, it doesnt get appended to the end.
I am adding a youtube URL and i pressed enter and I am getting this error This is because i am using the shorter URL link. When I put the full link it works correctly. Not a blocker.

mechakin commented 8 months ago

To answer your comments

We can make the widget toggle off by default
Do you want the YT widget to be appended at the end of all the icons?

As for the last comment that is really weird i've tested out this video and a couple others with the shortened link and it seemed to work just fine, there might be a weird bug in the regex to validate the link

Screenshot 2023-11-03 at 5 17 27 PM

mechakin commented 8 months ago

Took your feedback and made sure to fix the issues you addressed, however I wasn't able to replicate the issue where if the person adds the widget through the widget menu, the widget would automatically would be turned on.

That being said:

The bug with the shortened video link was because of a small issue with the regex where it would cut off the first letter of the URL if it started with a "v". Should all be fixed now.
The YT widget on the sidebar is now appended at the end.