Melkeydev / go-blueprint

Go-blueprint allows users to spin up a quick Go project using a popular framework
https://docs.go-blueprint.dev/
MIT License
5.2k stars 302 forks source link

feat: Check if templ and tailwindcss commands are available before #296

Closed jaswdr closed 2 months ago

jaswdr commented 3 months ago

building (#295)

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

When creating a new project for the first time, and having tailwindcss and templ options enable, the Makefile does not check if those commands are available. I'm adding a "check" step in the Makefile to do this, and redirect the user to installed them if they are not available.

Description of Changes:

Checklist

Ujstor commented 2 months ago

I saw the PR after I commented on the open issue ticket. I just didn't pick up on the fact that you mentioned it in the PR. First, we need to resolve the linter issue. I will leave my review shortly.

jaswdr commented 2 months ago

Thanks, I'll take a look and check how to do it in Windows

Ujstor commented 2 months ago

Thanks, I'll take a look and check how to do it in Windows

It would be nice to have a Windows implementation….something like 30% of blueprint users are on Win

Ujstor commented 2 months ago

here were other open issues related to the Makefile, and I resolved them all in one PR.

https://github.com/Melkeydev/go-blueprint/pull/306