ci: linting on generated code

Melkeydev / go-blueprint

Go-blueprint allows users to spin up a quick Go project using a popular framework

https://docs.go-blueprint.dev/

MIT License

5.98k stars 337 forks source link

ci: linting on generated code #47

Closed mimatache closed 1 year ago

mimatache commented 1 year ago

This PR will run golangci-lint against all the generated repositories.

Things to improve:

~~Don't install golangci-lint for each item in the matrix~~
Uses golangci-lint predefined action
Add a .golangci.yaml file with desired linter configuration

resolve #39

Melkeydev commented 1 year ago

Checking out this PR and on your local branch I see that all the builds are failing :thinking: https://github.com/mimatache/go-blueprint/actions

Is there working pipelines that I can see :sweat:

mimatache commented 1 year ago

Checking out this PR and on your local branch I see that all the builds are failing 🤔 https://github.com/mimatache/go-blueprint/actions

Is there working pipelines that I can see 😓

What is failing is not the new workflow, but the one was already failing the main repository earlier that is breaking my actions as well:

I can't seem to get the actions to trigger right now (didn't even see them running on mine before). Do you have any advice on how to get them to run (note, my workflow might not event start until it was merged into main).

mimatache commented 1 year ago

@Melkeydev can you try approving the workflows so we can see if they run/pass here? I don't have the option from my branch to run it.