search

Melkeydev / go-blueprint

Go-blueprint allows users to spin up a quick Go project using a popular framework
https://docs.go-blueprint.dev/
MIT License
5.96k stars 336 forks source link

feat: add spinner v4 #96

Closed mimatache closed 1 year ago

mimatache commented 1 year ago

The previous implementation for the spinner was entering interactive mode all the time, this caused GHA that would run go-blueprint at any point to fail. This affected the generate projects linting as of now, but any action that would use the go-blueprint create would have had the same issue.

Melkeydev commented 1 year ago

image

There is an issue going on with the go-routines. Potentially not being closed but once the true boolean flag gets passed into the channel, this message should no longer appear after the project was generated

CamPen21 commented 1 year ago

@mimatache Can we also get rid of lines 29 to 32 from the file .github/workflows/generate-linter.yml It does the same thing for every matrix arm and it generates errors.

mimatache commented 1 year ago

The channel right now is not properly configured

Removed the channel as it was not needed.

Melkeydev commented 1 year ago

I am wondering if it makes sense to also include a "Finished" when the job is done? Right now when the job completes the "preparing.." just stays there on the CLI.

Also: Nit - the spacing is a bit too big?

image