MellKam / soundify

🎧 Lightweight integration with the Spotify Web API for modern Javascript runtimes
https://npmjs.com/@soundify/web-api
MIT License
25 stars 3 forks source link

Episodes and Shows functionality #37

Closed danluki closed 1 year ago

danluki commented 1 year ago

Partly resolved #36 I implemented episodes and shows Spotify API functions, they are pretty much the same as album + tracks. So, the code is very close to them.

The steps I did:

  1. Saw how you implemented the same logic inside album and tracks.
  2. Created types for episode and track, which is close to album and tracks.
  3. Created new functions, that implements logic from episodes and tracks chapters of Spotify Docs.
  4. Also, I tested it a bit by hands and it seems to work good.
  5. Wrote some docs for new functionality.
  6. Run pnpm lint and default tests.
codecov-commenter commented 1 year ago

Codecov Report

Merging #37 (ab89968) into main (78e6662) will decrease coverage by 1.14%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main     #37      +/-   ##
=========================================
- Coverage   10.81%   9.67%   -1.14%     
=========================================
  Files          34      38       +4     
  Lines        4588    5126     +538     
  Branches       16      16              
=========================================
  Hits          496     496              
- Misses       4092    4630     +538     
Impacted Files Coverage Δ
src/api/endpoints.ts 0.00% <0.00%> (ø)
src/api/episode/episode.endpoints.ts 0.00% <0.00%> (ø)
src/api/episode/episode.types.ts 0.00% <0.00%> (ø)
src/api/general.types.ts 0.00% <0.00%> (ø)
src/api/index.ts 0.00% <0.00%> (ø)
src/api/show/show.endpoints.ts 0.00% <0.00%> (ø)
src/api/show/show.types.ts 0.00% <0.00%> (ø)
MellKam commented 1 year ago

Thank you so much for your contribution to the project! It looks like good quality code to me. In the future I would like to write tests for this and other functionality, but so far everything looks good. In the near future I will also try to make the contributors section in the readme. Thank's again!