search

Mellanox / ci-demo

Apache License 2.0
2 stars 20 forks source link

Use build args for Dockerfiles #5

Closed vasily-v-ryabov closed 3 years ago

vasily-v-ryabov commented 3 years ago

Many our internal Dockerfile's contain "ARG" statements at the beginning of Dockerfile. When we need "docker build", these ARGs are required. The error looks so:

+ docker build -t <censored> -f <Dockerfile> .
Sending build context to Docker daemon  9.502MB

Step 1/8 : ARG ARCH
Step 2/8 : ARG DISTRO
Step 3/8 : FROM <censored>
invalid reference format

@artemry-mlnx FYI

I think we need better solution in a mid-term so that ARGs are passed more explicitly and transparently. This is just a hotfix.

vasily-v-ryabov commented 3 years ago

I see ARG could be set in Jenkinsfile. So maybe this pull request is wrong. Looking into more opinions...

vasily-v-ryabov commented 3 years ago

bot:retest