issue: 3173318 Fixing the handling of null elements in iov tx vector. - Githubissues

Mellanox / libvma

Linux user space library for network socket acceleration based on RDMA compatible network adaptors

https://www.mellanox.com/products/software/accelerator-software/vma?mtag=vma

Other

559 stars 152 forks source link

issue: 3173318 Fixing the handling of null elements in iov tx vector. #1008

Closed AlexanderGrissik closed 1 year ago

AlexanderGrissik commented 1 year ago

Signed-off-by: Alexander Grissik agrissik@nvidia.com

Description

VMA passes tx to OS in case the one element of the iov vector is null. Thus, breaking the connection.

What

Skip null elements in iov vector but process those that are not null.

Why ?

It is not forbidden to have null element in the iov vector.
Kernel handles that well.
Couchbase server behaves like this.

Change type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Tests
[ ] Other

Check list

[X] Code follows the style de facto guidelines of this project
[X] Comments have been inserted in hard to understand places
[ ] Documentation has been updated (if necessary)
[ ] Test has been added (if possible)

AlexanderGrissik commented 1 year ago

bot::retest

AlexanderGrissik commented 1 year ago

bot:retest

AlexanderGrissik commented 1 year ago

bot:retest