Mellanox / libvma

Linux user space library for network socket acceleration based on RDMA compatible network adaptors
https://www.mellanox.com/products/software/accelerator-software/vma?mtag=vma
Other
585 stars 153 forks source link

issue: 1214066 Update some unsigned char -> uint32_t for table_id #1056

Closed jdrouhard closed 11 months ago

jdrouhard commented 11 months ago

Description

This fixes a few places that weren't updated from unsigned char to uint32_t when support for extended route and rule tables was done for issue 1214066 (a90d08dd5140e0cbc6b6a45ddf71ebda69bb4141)

What

Changes type for table_id from unsigned char -> uint32_t in more places.

Why ?

Extended routing table IDs overflow when used in these functions since unsigned char can only contain values up to 255 (8 bits) but extended table IDs can be 32 bits.

Change type

What kind of change does this PR introduce?

Check list

swx-jenkins3 commented 11 months ago

Can one of the admins verify this patch?

jdrouhard commented 11 months ago

Should I change the merge target to the 9.0_LTS branch? this bug actually hit us earlier this week when we set up some routing table policies.

jdrouhard commented 11 months ago

Ping @igor-ivanov @iftahl - not sure exactly how PRs in this repo get merged or how issues are tracked, but I just want to bring attention to this. This bug is causing us to not be able to use VMA since we rely on some policy based routing using extended table IDs which doesn't currently work without this bug fix.

igor-ivanov commented 11 months ago

@jdrouhard please update commit message using format as "issue: 1214066 Update ..."

igor-ivanov commented 11 months ago

bot:retest

AlexanderGrissik commented 11 months ago

bot:retest

AlexanderGrissik commented 11 months ago

bot:retest

AlexanderGrissik commented 11 months ago

bot:retest