issue: 3855390 Fixing adding TCP timer twice warning - Githubissues

Mellanox / libxlio

Other

32 stars 18 forks source link

issue: 3855390 Fixing adding TCP timer twice warning #130

Closed AlexanderGrissik closed 5 months ago

AlexanderGrissik commented 5 months ago

Description

In heavy CPS scenarios a socket may go to TIME-WAIT state and be reused before first TCP timer registration is performed by internal-thread.

What

Setting timer_registered=true while posting the event prevents the second attemp to try and post the event again.
Adding sanity check in add_new_timer that verifies that the socket is not already in the timer map.

Change type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Tests
[ ] Other

Check list

[ ] Code follows the style de facto guidelines of this project
[ ] Comments have been inserted in hard to understand places
[ ] Documentation has been updated (if necessary)
[ ] Test has been added (if possible)

galnoam commented 5 months ago

@AlexanderGrissik, should be merged in this version?