issue: 3858121 Fixing socket stats corruption on termination - Githubissues

Mellanox / libxlio

Other

32 stars 18 forks source link

issue: 3858121 Fixing socket stats corruption on termination #137

Closed AlexanderGrissik closed 3 months ago

AlexanderGrissik commented 3 months ago

Description

When sock_stats was static its destructor was called before xlio_exit that destroys the internal-thread which destroys sockets.

What

We should avoid having global objects with untrivial constructors/destructors, since there is no control of their execution order.

Why ?

Functionality

Change type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Tests
[ ] Other

Check list

[ ] Code follows the style de facto guidelines of this project
[ ] Comments have been inserted in hard to understand places
[ ] Documentation has been updated (if necessary)
[ ] Test has been added (if possible)