issue: 3875155 Fix cppcheck skipping files from scanning - Githubissues

Mellanox / libxlio

Other

32 stars 18 forks source link

issue: 3875155 Fix cppcheck skipping files from scanning #139

Closed pasis closed 2 months ago

pasis commented 3 months ago

Description

cppcheck skips most of the files from scanning and returns successfully. This potentially hides issues that can be detected in CI.

Replace #error with #warning in the endianness check to allow cppcheck to find a working configuration.

#warning still fails the compilation process, so we won't miss a wrong endianness configuration.

What

Replace #error with #warning in the endianness check to allow cppcheck to find a working configuration.

Why ?

Fix cppcheck job in CI.

Change type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Tests
[ ] Other

Check list

[ ] Code follows the style de facto guidelines of this project
[ ] Comments have been inserted in hard to understand places
[ ] Documentation has been updated (if necessary)
[ ] Test has been added (if possible)