Mellanox / libxlio

Other
41 stars 18 forks source link

issue: 3795997 Allow split segment with unacked q #145

Open iftahl opened 5 months ago

iftahl commented 5 months ago

When the send window is not big enough for the required TCP segment to send, we may split the segment so it will fit into the window. Before this change - We didn't split the segment in the case we have unacked segments. The motivation was that we anticipate to get ACK on the inflight segments, which will trigger the next send operation. This flow counts on RTT for receiving ACKs, which may be delayed depending on the remote side. When RTT is long - we would block sending although the TCP send window allows it.

The change is to split TCP segments although we have unacked data, in case the send window is big enough (mss).

Change type

What kind of change does this PR introduce?

Check list

iftahl commented 5 months ago

bot:retest

iftahl commented 4 months ago

@AlexanderGrissik can we merge it?

galnoam commented 4 months ago

@iftahl, please add statistics, @AlexanderGrissik asked.