Mellanox / network-operator

Mellanox Network Operator
Apache License 2.0
205 stars 50 forks source link

feat: Blacklist DOCA Drive modules on host #1086

Closed e0ne closed 1 day ago

e0ne commented 6 days ago

We should not allow to load inbox or OFED-on-host drivers if DOCA Driver container deployment is enabled.

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 11105757166

Details


Files with Coverage Reduction New Missed Lines %
api/v1alpha1/zz_generated.deepcopy.go 4 40.38%
controllers/hostdevicenetwork_controller.go 21 68.18%
<!-- Total: 25 -->
Totals Coverage Status
Change from base Build 10994266668: -0.1%
Covered Lines: 3317
Relevant Lines: 5509

💛 - Coveralls
rollandf commented 6 days ago

LGTM

e0ne commented 6 days ago

Only license header is updated during the last RP update

noama-nv commented 6 days ago

@e0ne with this change on reboot no driver will be loaded, no failsafe

what about workers where the mgmt is also mlnx?

e0ne commented 6 days ago

@e0ne with this change on reboot no driver will be loaded, no failsafe

what about workers where the mgmt is also mlnx? kubelet restarts all pods on

@e0ne with this change on reboot no driver will be loaded, no failsafe

what about workers where the mgmt is also mlnx?

preStop will be executed during the node reboot and driver will be loaded as expected

e0ne commented 6 days ago

@e0ne with this change on reboot no driver will be loaded, no failsafe

what about workers where the mgmt is also mlnx?

also, we don't update initramfs so modules will be loaded after reboot