Mellanox / network-operator

Mellanox Network Operator
Apache License 2.0
185 stars 47 forks source link

fix: refactor docker tag and helm version determination via triggers #945

Closed maze88 closed 1 month ago

maze88 commented 1 month ago

Git tag events (regardless of the branch) would not trigger the old workflow, and push branch events would trigger it - including the Helm CI, which would sometimes not be able to determine any version to set, thus failing.

This commit fixes the above, by:

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9169939491

Details


Files with Coverage Reduction New Missed Lines %
controllers/nicclusterpolicy_controller.go 1 78.21%
controllers/ipoibnetwork_controller.go 2 83.33%
pkg/state/state_ipoib_network.go 4 75.24%
<!-- Total: 7 -->
Totals Coverage Status
Change from base Build 9075384735: 0.1%
Covered Lines: 3254
Relevant Lines: 5070

💛 - Coveralls
e0ne commented 1 month ago

CI failures are not related to this change, so it's safe to merge