Mellanox / network-operator

Mellanox Network Operator
Apache License 2.0
185 stars 47 forks source link

[DNM] chore: Update NFD version to v0.15.4 #981

Open adrianchiris opened 1 week ago

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9698749749

Details


Files with Coverage Reduction New Missed Lines %
pkg/state/state_hostdevice_network.go 2 78.38%
pkg/state/state_skel.go 2 83.04%
api/v1alpha1/zz_generated.deepcopy.go 4 37.63%
controllers/hostdevicenetwork_controller.go 21 68.18%
<!-- Total: 29 -->
Totals Coverage Status
Change from base Build 9687201354: -0.5%
Covered Lines: 3201
Relevant Lines: 5089

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9699885488

Details


Files with Coverage Reduction New Missed Lines %
controllers/macvlannetwork_controller.go 2 86.25%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 9687201354: 0.2%
Covered Lines: 3235
Relevant Lines: 5089

💛 - Coveralls
adrianchiris commented 1 week ago

/retest-nic_operator_helm

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9742833080

Details


Files with Coverage Reduction New Missed Lines %
pkg/state/state_hostdevice_network.go 2 78.38%
controllers/nicclusterpolicy_controller.go 2 79.5%
pkg/state/state_skel.go 2 84.82%
api/v1alpha1/zz_generated.deepcopy.go 4 37.63%
controllers/ipoibnetwork_controller.go 5 77.38%
controllers/hostdevicenetwork_controller.go 15 75.0%
<!-- Total: 30 -->
Totals Coverage Status
Change from base Build 9739691930: -0.4%
Covered Lines: 3221
Relevant Lines: 5089

💛 - Coveralls
adrianchiris commented 1 week ago

/retest-all

adrianchiris commented 1 week ago

we should hold with this until issue[1] is resolved, then update to a version that contains the fix.

[1] https://github.com/kubernetes-sigs/node-feature-discovery/issues/1752

coveralls commented 6 days ago

Pull Request Test Coverage Report for Build 9760067150

Details


Files with Coverage Reduction New Missed Lines %
pkg/state/state_skel.go 4 83.63%
controllers/nicclusterpolicy_controller.go 9 75.31%
<!-- Total: 13 -->
Totals Coverage Status
Change from base Build 9739691930: -0.1%
Covered Lines: 3235
Relevant Lines: 5089

💛 - Coveralls