Add support for persistent vidmem pages

Mellanox / nv_peer_memory

292 stars 60 forks source link

Add support for persistent vidmem pages #100

Closed pakmarkthub closed 2 years ago

pakmarkthub commented 2 years ago

This PR:

introduces the NC client.
introduces nv_support_persistent_pages for checking whether nvidia.ko supports persistent pages.
implements nv_mem_get_pages_nc for the NC client to enable the persistent pages feature.
increases the version number to 1.3.

Note:

The NC client does not use struct peer_memory_client_ex because the invalidation path is not used.

tzafrir-mellanox commented 2 years ago

I'm not sure I like to have that branch merged inside the pull request. Needless complication of the graph. Furthermore, we have two commints, with the same name but different content ("Reverted create_nv.symvers.sh") one inside the merged branch and one outside it. I'm not really sure what they're supposed to do.

pakmarkthub commented 2 years ago

Hi @tzafrir-mellanox,

Thank you for reviewing the PR. This PR has been reviewed internally and those commits are the result of the review process. I can squash them if you think that is better. Do you have any recommendation?

gpaulsen commented 2 years ago

For what it's worth, I agree that a squash would be much more clear.

pakmarkthub commented 2 years ago

Ok. I have squashed the commits.