Mellanox / nv_peer_memory

305 stars 61 forks source link

nv_peer_mem dkms fails on ubuntu 18.04, #32

Closed JohnSpillerNvidia closed 6 years ago

JohnSpillerNvidia commented 6 years ago

I'm not sure if this is an issue with nv_peer_mem or with the something else, but trying to build the nv_peer_mem module against the 4.15.0-10 kernel in Ubuntu bionic fails because ACCESS_ONCE is undefined. ACCESS_ONCE was removed from compiler.h in the kernel in december 2017.

ferasd commented 6 years ago

You are right, the macro was removed from newer kernels. We may convert ACCESS_ONCE() to READ_ONCE(), I will create a pull request for that.

ferasd commented 6 years ago

@JohnSpillerNvidia can we close?

JohnSpillerNvidia commented 6 years ago

?I think so. I just got back from vacation and haven't tried your build, but I did exactly the same thing and it compiled before I left, so we should be fine.


From: ferasd notifications@github.com Sent: Wednesday, April 4, 2018 9:19 AM To: Mellanox/nv_peer_memory Cc: John Spiller; Mention Subject: Re: [Mellanox/nv_peer_memory] nv_peer_mem dkms fails on ubuntu 18.04, (#32)

@JohnSpillerNvidiahttps://github.com/JohnSpillerNvidia can we close?

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Mellanox/nv_peer_memory/issues/32#issuecomment-378659534, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWSCCFm6UzKbFo_qWQ8hxi8WwG0mVSrqks5tlPKagaJpZM4S5e5F.


This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.