search

Mellanox / rshim-user-space

Linux based user-space RSHIM driver for the Mellanox BlueField SoC
Other
24 stars 17 forks source link

bfb-install: Enable CLEAR_ON_READ #153

Closed lsun100 closed 5 months ago

lsun100 commented 5 months ago

rshim log buffer is only 1KB in size. Once full, it'll discard the rest of messages which might contain important messages for errors or installation completion. This commit enables CLEAR_ON_READ as a quick workaround to clear the log buffer after read during the polling of installation status. Since the log is cleared from the log buffer during bfb-install, file /tmp/bfb-install.log is create to preserve these logs in case it might be needed.

In next release, it's preferred to update the kernel driver on DPU side, such as by adding a new local buffer for Linux logging, or making the rshim log as circular buffer for logs from Linux.

RM #3908498

lsun100 commented 5 months ago

+2. Looks good to me.

Only comment is it might be helpful to indicate "CLEAR_ON_READ" is on in "misc" output, as it may confuse the user when Log Messages shows empty when the user cats the misc file during bfb-install.

Sorry, missed this comment. Yes, CLEAR_ON_READ will be displayed, but in "DISPLAY_LEVEL 1". Maybe I should move it to DISPLAY_LEVEL 2.