search

Mellanox / rshim-user-space

Linux based user-space RSHIM driver for the Mellanox BlueField SoC
Other
24 stars 17 forks source link

Make sending the initial force command a one-time event. #167

Closed pgeng-nv closed 3 months ago

pgeng-nv commented 3 months ago

Fix a bug https://redmine.mellanox.com/issues/4005070. The bug is that when host receives a misc command of "SW_RESET", BMC rshim will re-probe, causing ownership command to be resent, since that logic is inside the probe function.

This change moves setting the pending command flag logic to main() function right after parsing command line and loading the configuration file. It uses a global array to store the flag. So it makes sure the -F command line option or FORCE_MODE configuration file option is consumed only once, even when bd is reallocated in probing.

RM #4005070

lsun100 commented 3 months ago

https://redmine.mellanox.com/issues/4005070

Suggest removing the ' https://redmine.mellanox.com/issues/4005070', and change 'RM 4005070' to 'RM #4005070' for consistency.

pgeng-nv commented 3 months ago

https://redmine.mellanox.com/issues/4005070

Suggest removing the ' https://redmine.mellanox.com/issues/4005070', and change 'RM 4005070' to 'RM #4005070' for consistency.

I thought the comments above are just for the PR not the actual git commit? Will add "#" to the Git commit.