Mellanox / sockperf

Network Benchmarking Utility
Other
597 stars 119 forks source link

print date&time every time it is executed #162

Open O-ring opened 2 years ago

O-ring commented 2 years ago

Hello everyone,

a useful feature to have would be, for sockperf, to write the date and time (in UTC format) each time a test is run.

Cheers, Marco

ChrisCoe commented 2 years ago

A user could run something like date for UTC time so not sure why feature is needed in sockperf. Would date && <sockperf cmd> work for your case? Are you looking for date/time at a specific state of a run? If so, then a change like that could be useful.

O-ring commented 2 years ago

Hello Chris,

thanks for the response.

yes, I think it is useful that sockperf prints the date and time of when the test is run. Sometimes I forget to run 'date' and so I can't track back to when the test was run.

For example 'iperf3' always prints date and time on every test.

Marco

ChrisCoe commented 2 years ago

Hi Maro,

Gotcha, sounds reasonable to me.

I can work on this so UTC date/time is present at the start of each run (whether client or server). I'll try to get this in within a month from now (busy at the moment). Please feel free to jump in and make the change if you like.

My suggestion: Change should happen in src/sockperf.ccp, specifically right after line https://github.com/Mellanox/sockperf/blob/e92a8703a2cafe10a79c3e4bf806addb6ca5ffa1/src/sockperf.cpp#L3563 This way the UTC time is printed out before server/client distinction is made. Pseudo Code:

// Display UTC date and time 
 log_msg("<UTC TIME>");  

Example of current output where first line has version log: image

-Christian

O-ring commented 2 years ago

Hello Christian,

thanks for the response. I will wait for your update.

Marco